[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]
From:       Vikey Chen <duke () openjdk ! java ! net>
Date:       2022-03-29 17:08:46
Message-ID: VMrcnz20C7wHA_yZrFPGvDXVXhsDCwO_VlwC0HU07dc=.095f03a2-6b22-4d59-a4fd-e2cdf3f0ab1f () github ! com
[Download RAW message or body]

On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen <duke@openjdk.java.net> wrote:

> > From the test doc of openjdk \
> > https://openjdk.java.net/groups/build/doc/testing.html
> > > If your locale is non-US, some tests are likely to fail. To work around this \
> > > you can set the locale to US. On Unix platforms simply setting LANG="en_US" in \
> > > the environment before running tests should work. On Windows or MacOS, setting \
> > > JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US" helps for most, but not \
> > > all test cases.
> > 
> > However, on MacOS 12.1, running `make test-tier1 \
> > JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US"` command for tier-1 test, \
> > some tests still fail, including the following in tier-1.The tests expects output \
> > messages in English, but Chinese message are still produced. 
> > test/hotspot/jtreg/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java
> > test/langtools/jdk/javadoc/tool/6964914/TestStdDoclet.java
> > test/langtools/jdk/javadoc/tool/6964914/TestUserDoclet.java
> > test/langtools/jdk/javadoc/tool/EnsureNewOldDoclet.java
> > test/langtools/jdk/javadoc/tool/testLocaleOption/TestLocaleOption.java
> > test/langtools/tools/javac/T8132562/ClassPathWithDoubleQuotesTest.java
> > test/langtools/tools/javac/options/smokeTests/OptionSmokeTest.java
> > test/langtools/tools/javac/platform/PlatformProviderTest.java
> > test/langtools/tools/jdeps/MultiReleaseJar.java
> 
> Vikey Chen has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Locale.ENGLISH to Locale.US

I have tested some of the failed 9 tests above on windows with `Cygwin`. The tests \
fail as i thought. I think this PR can have an effect for windows users, too.   On \
windows the default locale seems to be determined by system api, too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7924


[prev in list] [next in list] [prev in thread] [next in thread]