[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: 8203290: [AIX] Check functionality of JDK-8199712 (Flight Recorder)
From:       Tyler Steele <duke () openjdk ! java ! net>
Date:       2022-02-17 8:53:18
Message-ID: duKbwvxYFB-YMRPrPRX8ffBwNVqiWRouRFIXqfS8dNY=.31d60e36-5d16-4c3a-b0a2-5f66e4432b26 () github ! com
[Download RAW message or body]

On Fri, 17 Dec 2021 19:07:54 GMT, Tyler Steele <duke@openjdk.java.net> wrote:

> Just in time for the holidays I have completed an implementation of the JFR \
> functionality for AIX. As a side note, this is my first submission to OpenJDK 👋 
> ### Implementation notes and alternatives considered
> 
> After modifying the build system to allow the --enable-jvm-feature-jfr to work on \
> AIX, my task was to implement the interfaces from os_perf.hpp. The os_perf_aix.cpp \
> implementation that existed was, I believe, a copy of the Linux implementation. A \
> review of the code in that file showed that NetworkInterface, \
> CPUPerformanceInterface, and SystemProcessInterface would require modification to \
> work on AIX. Using the Linux implementation as a guide, I initially expected to use \
> files from the aix procfs like /proc/<pid>/psinfo, and /proc/<pid>/status in a \
> manner similar to the Linux implementation. However, I ended up using libperfstat \
> for all functionality required by the interfaces. 
> ### Testing
> 
> Testing for JFR seems to be quite light in the repo both before and after this \
> change. In addition to performing manual testing, I have added some basic sanity \
> checks that ensure events can be created and committed (using jtreg), and performs \
> some basic checks on the results of the interface member functions (using gtest). 
> ### More notes
> 
> I've sent an email to the JFR group about a TOC overflow warning I encountered \
> while building (for the release server target). I believe the fix is to pass \
> -qpic=large when using the xlc toolchain, but my modifications to flags-cflags.m4 \
> have not been successful in removing this warning.

This pull request has now been integrated.

Changeset: c0275e18
Author:    Tyler Steele <tyler.steele@ibm.com>
Committer: Thomas Stuefe <stuefe@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c0275e18b7cb4a01385b79ced46560322aeacc97
                
Stats:     1230 lines in 10 files changed: 461 ins; 502 del; 267 mod

8203290: [AIX] Check functionality of JDK-8199712 (Flight Recorder)

Implements JFR for AIX

Reviewed-by: erikj, mdoerr, mgronlun, stuefe, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885


[prev in list] [next in list] [prev in thread] [next in thread]