[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling [v4]
From:       Aleksey Shipilev <shade () openjdk ! java ! net>
Date:       2022-02-16 20:12:14
Message-ID: W5UXyA_CU2gQecb5mOb1F5rSXzfn_-M6aot5cJ1-o68=.0e1390d5-d5ad-4293-a44b-9ca5f56b164e () github ! com
[Download RAW message or body]

On Wed, 16 Feb 2022 08:03:53 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > A test failure reproduces in GHA in x86_32 mode. Reproduces locally too:
> > 
> > 
> > $ CONF=linux-x86-server-fastdebug make run-test \
> > TEST=serviceability/7170638/SDTProbesGNULinuxTest.java 
> > java.lang.Error: java.lang.RuntimeException: '.note.stapsd' missing from stdout
> > 
> > at SDTProbesGNULinuxTest.testLibJvm(SDTProbesGNULinuxTest.java:76)
> > at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> >  at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
> >  at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> >  
> > 
> > The reason is that the new test now enables `DTraceMethodProbes`, \
> > `DTraceAllocProbes`, `DTraceMonitorProbes`, but VM never actually checks those \
> > options are available. So test thinks dtrace support is there, yet there are no \
> > relevant sections in `libjvm.so`, so the test fails. We should extend the \
> > argument checks to those three options too. 
> > Unfortunately, there are tests that do `DTrace*` flags, we should make them sense \
> > the build capability, and act accordingly. This simplifies some existing tests \
> > too. 
> > Additional testing:
> > - [x] Linux x86_64 fastdebug (dtrace enabled), affected test still passes
> > - [x] Linux x86_32 fastdebug (dtrace disabled due to missing dependencies), \
> > affected test now passes
> 
> Aleksey Shipilev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Test8168712 non-dtrace config

Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7477


[prev in list] [next in list] [prev in thread] [next in thread]