[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8277946: NMT: Deprecate and remove VM.native_memory shutdown jcmd command option
From:       Aleksey Shipilev <shade () openjdk ! java ! net>
Date:       2021-11-30 20:52:09
Message-ID: DDb-Ozma17sppl_abeLkkvYZNCZQ-hiuokOLqrUOUE8=.41c5d7e8-6925-4e16-a453-b4454bfbf3fd () github ! com
[Download RAW message or body]

On Tue, 30 Nov 2021 15:17:10 GMT, Zhengyu Gu <zgu@openjdk.org> wrote:

> NMT shutdown functionality is a remnant of its first implementation, which could \
> consume excessive amount of memory, therefore, it needed capability to shut it self \
> down to ensure health of JVM. This is no longer a case for new implementation. 
> NMT shutdown can be requested via Jcmd. However, it is rare used.
> 
> We should deprecate for shutdown Jcmd command for removing NMT shutdown \
> functionality. 
> Corresponding [CSR](https://bugs.openjdk.java.net/browse/JDK-8277947) has been \
> approved.

Looks fine. I wonder: was `NMT_minimal` the state after "shutdown"? If so, should it \
be removed too? (in separate PR, probably)

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6618


[prev in list] [next in list] [prev in thread] [next in thread]