[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: JDK-8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX p
From:       Lutz Schmidt <lucy () openjdk ! java ! net>
Date:       2021-09-30 16:33:51
Message-ID: fr7BpfOTddLRBf7aNUkUqS61ebw5LMHKdOHch7fRbxw=.7ad3b0f4-ae87-4ab6-8fbe-588587d578ba () github ! com
[Download RAW message or body]

On Tue, 28 Sep 2021 11:13:00 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> Hello, please review this small change.
> The os::get_default_process_handle and os::dll_lookup functions are pretty similar \
> across the POSIX platforms so they can be moved to os_posix.cpp.

Changes look good to me. 
With respect to the Apple special casing I have requested an opinion from \
knowledgeable people. I would suggest to wait 24 hours for feedback.

-------------

Changes requested by lucy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5737


[prev in list] [next in list] [prev in thread] [next in thread]