[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8265933: Move Java monitor related fields from class Thread to JavaThread
From:       Patricio Chilano Mateo <pchilanomate () openjdk ! java ! net>
Date:       2021-04-29 18:15:58
Message-ID: 2hXQL8jbknlqFDF_-rjGxJnbBHbVr-2NTJMA2OtRupo=.2d2a16bb-20c5-4a54-b1d0-b3fb7dd94c78 () github ! com
[Download RAW message or body]

On Wed, 28 Apr 2021 14:05:38 GMT, Robbin Ehn <rehn@openjdk.org> wrote:

> > Hi,
> > 
> > Please review the following change. Fields in class Thread related to Java object \
> > monitors like _current_pending_monitor, _current_pending_monitor_is_from_java, \
> > _current_waiting_monitor and _Stalled should be moved to the JavaThread class. \
> > Members _OnTrap and _TypeTag were grouped together with _Stalled but are not used \
> > so I removed them. It seems they were part of the ObjectMonitor implementation at \
> > some point but I couldn't find how they were used. Tested in mach5 tier1-2.
> > 
> > Thanks,
> > Patricio
> 
> Marked as reviewed by rehn (Reviewer).

Thanks @robehn, @dcubed-ojdk, @dholmes-ora and @coleenp for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3722


[prev in list] [next in list] [prev in thread] [next in thread]