[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing 
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2021-04-27 23:17:10
Message-ID: VfmfP_buTVP2EjQNaf2Gu28XXPnX3ec4ydO9IpnnPko=.c5fd82a8-4333-4975-a83a-91363cfde21a () github ! com
[Download RAW message or body]

On Tue, 27 Apr 2021 22:55:27 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > We currently have array_klass() and array_klass_or_null(), where the former can \
> > throw exceptions and the latter can not. But they both delegate to: 
> > array_klass_impl(bool or_null, TRAPS)
> > 
> > which combines both the exception-throwing and non-exception-throwing code into \
> > one method declared with TRAPS. To make progress with the change of TRAPS to \
> > JavaThread (JDK-8252685) we need to separate these code paths into distinct \
> > methods. 
> > Testing: tiers 1-3 (in progress)
> > 
> > Thanks,
> > David
> 
> David Holmes has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Updated comment and simplify code structure in one method

Latest version looks good.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3711


[prev in list] [next in list] [prev in thread] [next in thread]