[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8264412: AArch64: CPU description should refer DMI [v2]
From:       Yasumasa Suenaga <ysuenaga () openjdk ! java ! net>
Date:       2021-03-31 13:34:16
Message-ID: zzGykadc52EkLxJ7s6O32qm6NBi6Odb7i5Zg9qsF99g=.f05adf05-2c19-47c5-affd-22fe51391ca8 () github ! com
[Download RAW message or body]

On Wed, 31 Mar 2021 08:45:06 GMT, Andrew Haley <aph@openjdk.org> wrote:

> > Please be more explicit. This is (perhaps obviously?) a workaround for a bug, And \
> > t.his code is itself a bug, because it doesn't check for the condition you care \
> > about. So, please check explicitly for this condition: `\n` only, and nothing \
> > else. And leave a comment explaining why.
> 
> One other thing I missed last time around: why is there a permanently-allocated 4k \
> buffer for this code that it only used for jfr?

I pushed new commit with some refactoring.

> Please be more explicit. This is (perhaps obviously?) a workaround for a bug, And \
> t.his code is itself a bug, because it doesn't check for the condition you care \
> about. So, please check explicitly for this condition: \n only, and nothing else. \
> And leave a comment explaining why.

I've done so in new commit.

> One other thing I missed last time around: why is there a permanently-allocated 4k \
> buffer for this code that it only used for jfr?

Some features (e.g. hs_err log, VM.info dcmd) dumps /proc/cpuinfo, so I guess this \
feature is used JFR only now. However CPU description has different information (for \
AArch64 at least), so we might be able to use it in other place, but it is out of \
scope this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3259


[prev in list] [next in list] [prev in thread] [next in thread]