[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with cl
From:       Jie Fu <jiefu () openjdk ! java ! net>
Date:       2020-10-27 4:43:19
Message-ID: YClh9g97LLLEIExX9QcPdf9kw5ExnWm5t5RQ4wymMko=.740605e9-8c73-472f-be9a-58ffab920072 () github ! com
[Download RAW message or body]

On Tue, 27 Oct 2020 01:37:31 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Hi all,
> > 
> > It's time to replace __sync_add_and_fetch with __atomic_add_fetch to avoid build \
> > errors.  
> > After JDK-8252221, build errors with clang were observed [1] due to the use of \
> > __sync_add_and_fetch, which is legacy and will be deprecated in the future. It \
> > can be reproduced by building macos-x86-zero or linux-x86-zero with clang. 
> > The fix was prepared by learning from aarch64's implementation [2].
> > Please review it.
> > 
> > Thanks
> > Best regards,
> > Jie
> > 
> > [1] https://bugs.openjdk.java.net/browse/JDK-8255040
> > [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp#L39
> > 
> 
> Hi Jie,
> 
> LGTM.
> 
> Thanks,
> David

Thanks @dholmes-ora and @kimbarrett for your review.
Will push it later.

-------------

PR: https://git.openjdk.java.net/jdk/pull/803


[prev in list] [next in list] [prev in thread] [next in thread]