[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8253920: Share method trampolines in CDS dynamic archive [v3]
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2020-10-27 0:36:18
Message-ID: -POv3g6_4gAP5exRJOMGvW7MD2cO4TkkxCp-VA8KCdw=.b81dae40-1945-492b-9253-535d5685dde7 () github ! com
[Download RAW message or body]

On Mon, 26 Oct 2020 22:48:35 GMT, Calvin Cheung <ccheung@openjdk.org> wrote:

> > This patch is to allow sharing of the same method trampoline for archived Methods \
> > with the same AdapterHandleEntry when using CDS dynamic archive.  
> > Running javac on HelloWorld with CDS dynamic archive, the number of calls to \
> > SharedRuntime::generate_trampoline() is reduced to 406 times vs 12601 times \
> > without the patch. 
> > In terms of saving on instructions and time (on linux-x64):
> > instr delta =     -2807662    -0.1369%
> > time  delta =       -6.860 ms -1.8798%
> > 
> > It passed tiers 1,2,3,4 testing.
> 
> Calvin Cheung has updated the pull request incrementally with one additional commit \
> since the last revision: 
> update with patch from Ioi

Marked as reviewed by iklam (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/868


[prev in list] [next in list] [prev in thread] [next in thread]