[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
From:       Lois Foltan <lfoltan () openjdk ! java ! net>
Date:       2020-09-28 14:04:31
Message-ID: vX6G1iMaHd19AbLpDb4oK6lZ9Qad9he9k9hxE1fyKWo=.9c490ace-9976-4da3-9847-ccb700a8bc7b () github ! com
[Download RAW message or body]

On Fri, 25 Sep 2020 18:19:26 GMT, Ioi Lam <iklam@openjdk.org> wrote:

> Please review this trivial fix for older clang compiler printf format warning. As \
> mentioned on [JDK-8253548](https://bugs.openjdk.java.net/browse/JDK-8253548), \
> these's an existing typecast in [logFileOutput.cpp]( \
> https://github.com/openjdk/jdk/blame/efd10546865998028aa6d34cf939ca0de67a90fc/hotspot/src/share/vm/logging/logFileOutput.cpp#L194)
>  for the same reason that SIZE_MAX is not actually of the size_t type for older \
> clang compilers.  Testing with mach5 tier1.

Looks good & trivial.

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/365


[prev in list] [next in list] [prev in thread] [next in thread]