[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8248112: array index out of bound in FileMapInfo::check_paths
From:       Calvin Cheung <calvin.cheung () oracle ! com>
Date:       2020-06-26 18:28:36
Message-ID: f3327d59-1d95-5911-46c3-1c1d95695802 () oracle ! com
[Download RAW message or body]

Thanks Yumin.

Calvin

On 6/26/20 10:29 AM, Yumin Qi wrote:
> +1
>
>
> Thanks
>
> Yumin
>
> On 6/25/20 10:36 PM, Ioi Lam wrote:
>> Hi Calvin,
>>
>> The changes look good to me.
>>
>> Thanks
>> - Ioi
>>
>> On 6/25/20 6:01 PM, Calvin Cheung wrote:
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8248112
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/jdk16/8248112/webrev.00/
>>>
>>> create_path_array() ignores non-existing paths. Although the dump 
>>> time and
>>> runtime app classpath lengths are the same initially, after the call to
>>> create_path_array(), the runtime app classpath length could become
>>> shorter. We consider app classpath mismatch in this case.
>>>
>>> Similar check should be applied to bootclasspath as well.
>>>
>>> Testing: appcds tests locally on linux-x64
>>>              tier1 and 2 tests (in progress)
>>>
>>> thanks,
>>>
>>> Calvin
>>>
>>>
>>>
>>
[prev in list] [next in list] [prev in thread] [next in thread]