[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): 8245521: Remove STACK_BIAS
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2020-05-26 19:46:25
Message-ID: C91F2A94-1062-4C60-8964-9C64F6989670 () oracle ! com
[Download RAW message or body]


David/Matthias/Vladimir, thanks for the reviews! Change pushed.

Cheers,
Mikael

> On May 26, 2020, at 12:01 PM, Vladimir Kozlov <vladimir.kozlov@oracle.com> wrote:
> 
> On 5/21/20 9:11 PM, David Holmes wrote:
> > Hi Mikael,
> > Looks good.
> 
> +1
> 
> > I assume the change to GraalHotSpotVMConfig.java is to allow it to work with \
> > older VMs?
> 
> Yes. stackBias will be set to 0 if STACK_BIAS is not present. Otherwise it will be \
> set to STACK_BIAS value. 
> Thanks,
> Vladimir
> 
> > Thanks,
> > David
> > On 22/05/2020 1:36 pm, Mikael Vidstedt wrote:
> > > 
> > > Please review this small change which removes the STACK_BIAS constant and its \
> > > uses: 
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8245521
> > > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8245521/webrev.00/open/webrev/
> > >  
> > > Background (from JBS):
> > > 
> > > With Solaris/SPARC removed the STACK_BIAS definition in \
> > > src/hotspot/share/utilities/globalDefinitions.hpp is now always 0 and can be \
> > > removed. 
> > > 
> > > Testing:
> > > 
> > > Tier1
> > > 
> > > Cheers,
> > > Mikael
> > > 


[prev in list] [next in list] [prev in thread] [next in thread]