[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (T) 8244107: Incorrect parameters in ReservedSpace constructor change
From:       coleen.phillimore () oracle ! com
Date:       2020-04-30 13:46:20
Message-ID: 0af369a3-89c5-0f40-32a9-01e63f13df57 () oracle ! com
[Download RAW message or body]


Thanks David and thank you for finding the bug.
Coleen

On 4/30/20 9:31 AM, David Holmes wrote:
> LGTM!
> 
> Thanks,
> David
> 
> On 30/04/2020 10:33 pm, coleen.phillimore@oracle.com wrote:
> > Summary: Revert cardTable.cpp change from JDK-8243393.
> > 
> > The change to make ReservedSpace constructors less easy to resolve to 
> > the wrong one didn't quite succeed since I did just that.
> > Tested with tier1.
> > 
> > JDK-8243393 change:
> > 
> > http://cr.openjdk.java.net/~coleenp/2020/8243393.01/webrev/src/hotspot/share/gc/shared/cardTable.cpp.udiff.html \
> >  
> > 
> > This webrev:
> > 
> > open webrev at 
> > http://cr.openjdk.java.net/~coleenp/2020/8244107.01/webrev
> > bug link https://bugs.openjdk.java.net/browse/JDK-8244107
> > 
> > Thanks,
> > Coleen


[prev in list] [next in list] [prev in thread] [next in thread]