[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(T) : 8243945 : use driver mode in runtime tests
From:       Igor Ignatyev <igor.ignatyev () oracle ! com>
Date:       2020-04-30 2:54:14
Message-ID: 2498C130-C8EB-474A-8827-5E341A0FC99A () oracle ! com
[Download RAW message or body]

Thanks David, pushed.

> On Apr 29, 2020, at 5:08 PM, David Holmes <david.holmes@oracle.com> wrote:
> 
> Hi Igor,
> 
> On 30/04/2020 5:19 am, Igor Ignatyev wrote:
> > http://cr.openjdk.java.net/~iignatyev//8243945/webrev.00/
> > > 143 lines changed: 46 ins; 0 del; 97 mod;
> > Hi all,
> > could you please review the trivial patch which updates 109 runtime tests to use \
> > driver mode? in most cases, the changes are as straightforward as \
> >                 's/main/driver/', other changes are:
> > - runtime/InvocationTests tests throw an exception instead of calling System.exit
> > - runtime/condy/CondyLDCTest.java passes "-Xverify:all", although the test didn't \
> >                 do that before, it seems it was intended, in any case it won't \
> >                 cause any harm
> > - in runtime/records/ignoreRecordAttribute.java, indent of jtreg test description \
> > block was fixed.
> 
> That all looks good - including the updates you did for Dan/Gerard!
> 
> > webrev: http://cr.openjdk.java.net/~iignatyev//8243945/webrev.00
> > (for the sake of reviewers, copyright year changes are omitted, the final patch \
> > changes years in )
> 
> Given malformed copyright lines can now cause a tier3 build failure, please be \
> extra careful with those updates :) Personally I don't mind seeing the copyright \
> changes in a webrev. 
> Thanks,
> David
> -----
> 
> 
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8243945
> > testing: test/hotspot/jtreg/runtime
> > Thanks,
> > -- Igor


[prev in list] [next in list] [prev in thread] [next in thread]