[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8241837: Cleanup stringStream usage in ObjectSynchronizer
From:       Claes Redestad <claes.redestad () oracle ! com>
Date:       2020-03-31 14:30:32
Message-ID: ae341176-997a-4d9e-faea-1d83cea7f639 () oracle ! com
[Download RAW message or body]



On 2020-03-31 16:09, Daniel D. Daugherty wrote:
> On 3/30/20 7:02 PM, Claes Redestad wrote:
>> Hi,
>>
>> this removes one unused stringStream, and refactors two other
>> so that they're only defined in the slow path error where they are used:
>>
>> http://cr.openjdk.java.net/~redestad/8241837/open.00/
> 
> src/hotspot/share/runtime/synchronizer.cpp
>      No comments.
> 
> Just FYI: ObjectMonitor::is_busy_to_string() calls stringStream::base()
> so the cleanup is handled by the stringStream destructor. I didn't want
> ResourceMarks.
> 
> Thumbs up.

Thanks!

/Claes
> 
> Dan
[prev in list] [next in list] [prev in thread] [next in thread]