[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): https://bugs.openjdk.java.net/browse/JDK-8240258
From:       Yumin Qi <yumin.qi () oracle ! com>
Date:       2020-02-29 3:24:39
Message-ID: 008d51f8-9308-3c37-7f2b-37b66044ab15 () oracle ! com
[Download RAW message or body]

I made the change.


Thanks

Yumin

On 2/28/20 7:17 PM, Calvin Cheung wrote:
> Hi Yumin,
>
> Looks good.
>
> The block of code between lines 1157 and 1381 already enclosed by #if 
> INCLUDE_CDS, so I'd suggest moving the quick_resolve function to 
> before line 1381. This would avoid having another #if INCLUDE_CDS in 
> this file. It's up to you if you want to make this change.
>
> thanks,
> Calvin
> On 2/28/20 7:03 PM, Yumin Qi wrote:
>> Hi,
>>
>>   Can I have a quick review for this XS change as supplemental fix to 
>> https://bugs.openjdk.java.net/browse/JDK-8236604.
>>
>>   Bug: https://bugs.openjdk.java.net/browse/JDK-8240258
>>
>>   Webrev: http://cr.openjdk.java.net/~minqi/8240258/webrev/
>>
>>   Summary: need CDS guard the new added function 
>> SystemDictionary::quick_resolve.
>>
>>    The other issue related to CDS guard is handled with 
>> https://bugs.openjdk.java.net/browse/JDK-8240254.
>>
>> Thanks
>>
>> Yumin
>>
[prev in list] [next in list] [prev in thread] [next in thread]