[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8239568: https://bugs.openjdk.java.net/browse/JDK-8239568
From:       Harold Seigel <harold.seigel () oracle ! com>
Date:       2020-02-28 14:18:03
Message-ID: efc62480-7fa8-af73-bd06-7dfe6242faba () oracle ! com
[Download RAW message or body]

Thanks Leonid!

I'll add code to throw jtreg.SkippedException before pushing the 
change.  I updated the webrev in place.

Harold

On 2/27/2020 6:41 PM, Leonid Mesnik wrote:
> Hi
>
> Overall looks good. You might want to throw jtreg.SkippedException if 
> class is not unloaded. So it is possible to track if test was actually 
> completed or failed to meet some conditions.
>
> Leonid
>
> On 2/24/20 1:43 PM, Harold Seigel wrote:
>> Hi,
>>
>> Please review this change to fix test LoadLibraryTest.java.  The fix 
>> changes the test to use inner classes.  Also, it only checks for the 
>> "Unloaded library ..." logging message if the class that loaded the 
>> shared library actually got unloaded.  And, the -Xmn8m flag to 
>> increase the chance that the class got unloaded.
>>
>> Open Webrev: 
>> http://cr.openjdk.java.net/~hseigel/bug_8239568/webrev/index.html
>>
>> JBS Bug: 
>> http://cr.openjdk.java.net/~hseigel/bug_8239568/webrev/index.html
>>
>> The modified test was tested on Linux-x64, Windows, and Mac OS X.
>>
>> Thanks, Harold
>>
[prev in list] [next in list] [prev in thread] [next in thread]