[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS) 8232734 [TESTBUG] avoid using JDK symbols in ExtraSymbols.symbols.txt
From:       Ioi Lam <ioi.lam () oracle ! com>
Date:       2019-10-31 21:56:15
Message-ID: 9b1b502d-cfd8-fb31-fc41-ef03e04b6c97 () oracle ! com
[Download RAW message or body]

Hi Calvin,

Thanks for the review.

I'll add two more test cases:

                        appendSymbol(fw, ""); // empty string
                        appendSymbol(fw, "Hello_\uffff");


The generated config file looks like this:

5 -1: Hello
0 -1:
7 -1: Hello_\x01
8 -1: Hello_\xc3\xbf
9 -1: Hello_\xe1\x88\xb4
9 -1: Hello_\xef\xbf\xbf
10 -1: NewSymbol0
10 -1: NewSymbol1
10 -1: NewSymbol2
.....


Thanks
- Ioi

On 10/31/19 12:27 PM, Calvin Cheung wrote:
> Hi Ioi,
>
> The removed ExtraSymbols.symbols.txt contains a zero-length symbol as 
> follows:
>
> 0 -1:
>
> Maybe the above could be added in ExtraSymbols.makeLotsExtraSymbols()?
>
> Looks good otherwise.
>
> thanks,
>
> Calvin
>
> On 10/30/19 7:33 PM, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232734
>> http://cr.openjdk.java.net/~iklam/jdk14/8232734-avoid-jdk-symbols-in-extra-symbols-test.v01/ 
>>
>>
>> ExtraSymbols.symbols.txt contains symbols that were once
>> extracted from the JDK. This has caused confusion when
>> developers are removing APIs from the JDK, and they are not
>> sure if they should also remove the corresponding symbols in
>> this file.
>>
>> In this patch, ExtraSymbols.symbols.txt is removed altogether. Instead,
>> a text file is generated at run time to cover the necessary cases.
>>
>> Tested with hs-tier1/2.
>>
>> Thanks
>> - Ioi
>>

[prev in list] [next in list] [prev in thread] [next in thread]