[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8233159: Method::result_type should use calculated value in constMethod
From:       Claes Redestad <claes.redestad () oracle ! com>
Date:       2019-10-30 14:53:25
Message-ID: 95542692-45e9-3358-cf54-23b84dffede3 () oracle ! com
[Download RAW message or body]

On 2019-10-30 15:25, coleen.phillimore@oracle.com wrote:
> 
> 
> On 10/30/19 9:51 AM, Claes Redestad wrote:
>> Hi Coleen,
>>
>> Any particular place where you think we can trivially remove
>> ResultTypeFinder use?
>>
> 
> There's one in defaultMethods.cpp but it's a bit more work to change it.

Yes, and it's only called in the relatively uncommon cases where we need
to create an overpass. I'm keen to revisit defaultMethods to see if we
can speed it up further, though.

> 
> There's one in jvmtiEnvBase, that could be:
> 
>     // Get information about method return type
>     Symbol* signature = jvf->method()->signature();
> 
>     TosState fr_tos = as_TosState(jvf->method()->result_type());
> 
> I thought there were more at first glance.   Your change is fine. The 
> jvmtiEnvBase code doesn't matter for performance.

Ok, thanks, I'll move ahead with it. :-)

/Claes
[prev in list] [next in list] [prev in thread] [next in thread]