[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S/L): 8230184 rename, whitespace, indent and comments changes in preparation for lock free M
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2019-08-28 21:46:33
Message-ID: e98f4999-607f-3d52-458a-d51e5bc4c222 () oracle ! com
[Download RAW message or body]

On 8/28/19 5:37 PM, coleen.phillimore@oracle.com wrote:
>
>
> On 8/27/19 6:29 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> This is my first set of JDK14 baseline cleanup changes extracted from 
>> the
>> Async Monitor Deflation project (JDK-8153224).
>>
>> This is an "S" review because it is conceptually Small. It is also an 
>> "L"
>> review because it has a mind numbingly Large number of cleanup changes.
>> Coleen, should appreciate this one since it takes care of a number of
>> naming issues that she (and others) have wanted to see fixed for years.
>
> Thank you for doing this and thank you to the reviewers of this!

You are quite welcome... lock-free Monitor List management provided the
impetus so some progress was made... I think the reviewers will recover
from the eye strain sometime next week... :-O

Dan


> Coleen
>>
>> As usual, the bug report has a yacky description of what I'm cleaning up
>> this round and why:
>>
>>      JDK-8230184 rename, whitespace, indent and comments changes in 
>> preparation
>>                           for lock free Monitor lists
>>      https://bugs.openjdk.java.net/browse/JDK-8230184
>>
>> Here's the webrev URL:
>>
>> http://cr.openjdk.java.net/~dcubed/8230184-webrev/0_for_jdk14/
>>
>> This webrev is relative to jdk-14+11.
>>
>> This fix is included in my latest round of JDK-8153224 testing which
>> included Mach5 Tier[1-8], my stress kit on Linux-X64 and Solaris-X64,
>> my Inflate2 test running in parallel with Kitchensink8H on macOSX,
>> Linux-X64 and Solaris-X64. I also ran the Inflate2 and Kitchensink8H
>> combo in parallel on the jdk-14+11 baseline + this fix on macOSX,
>> Linux-X64 and Solaris-X64. No regressions were observed in any of
>> the testing.
>>
>> Thanks, in advance, for any comments, suggestions or questions.
>>
>> Dan
>

[prev in list] [next in list] [prev in thread] [next in thread]