[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8228507: Archive FDBigInteger
From:       Brian Burkhalter <brian.burkhalter () oracle ! com>
Date:       2019-08-23 18:23:30
Message-ID: 56746D44-A746-4A81-9317-FF87EF5A2EEE () oracle ! com
[Download RAW message or body]

Hi Claes,

Looks good. One picayune comment: maybe move lines 155-157 to just before line 79.

Thanks,

Brian

> On Jul 24, 2019, at 2:42 AM, Claes Redestad <claes.redestad@oracle.com> wrote:
> 
> any double<->String conversion will trigger load of
> jdk.internal.math.FDBigInteger, which has a static
> initializer pre-calculating a relatively large number
> of values.
> 
> Archiving these pre-calculated values reduces the time
> spent in FDBigInteger.<clinit> from a couple of
> milliseconds down to "nothing".
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8228507 \
>                 <https://bugs.openjdk.java.net/browse/JDK-8228507>
> Webrev: http://cr.openjdk.java.net/~redestad/8228507/open.00/ \
> <http://cr.openjdk.java.net/~redestad/8228507/open.00/> 
> Testing: tier1-3


[prev in list] [next in list] [prev in thread] [next in thread]