[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8226779: [TESTBUG] Test JFR API from Java agent
From:       Erik Gahlin <erik.gahlin () oracle ! com>
Date:       2019-08-22 14:13:14
Message-ID: 5D5EA2FA.5090308 () oracle ! com
[Download RAW message or body]

Looks good!

Erik
> After feedback and some refactoring from Erik, here is the updated 
> webrev:
>
>     http://cr.openjdk.java.net/~mseledtsov/8226779.03/
>
>      JavaAgentBuilder.java - a utility class that can be reused to 
> build common java agents for testing
>
>      EventEmitterAgent.java  - the agent that emits JFR events
>
>      TestLoadedAgent.java, TestPremainAgent.java - actual tests
>
>
> Testing:
>
>   Ran many times on Mac, Linux-x64: all PASS
>
>   Ran many times on multiple platforms in test cluster: in progress
>
>
> Thank you,
>
> Misha
>
>
> On 8/12/19 7:40 PM, mikhailo.seledtsov@oracle.com wrote:
>> During conversation Erik and Markus have recommended the following 
>> changes:
>>
>>   - change the package (and test location) to jdk.jfr.javaagent
>>
>>   - extract agent-related utility methods into a utility class
>>
>> Here is an updated webrev: 
>> http://cr.openjdk.java.net/~mseledtsov/8226779.02/
>>
>>
>> Thanks,
>>
>> Misha
>>
>> On 7/26/19 3:08 PM, mikhailo.seledtsov@oracle.com wrote:
>>> Please review this new test. It is testing interaction between JFR 
>>> and Java Agent,
>>> creating recordings from within Java agent, both premain() and 
>>> agentmain().
>>> This is also a bit of a stress test since it tests large number of 
>>> recordings from
>>> multiple threads, from the agent, hence I placed it under 
>>> jfr/stress/javaagent.
>>>
>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8226779
>>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8226779.00/
>>>     Testing:
>>>       1. Running the test itself multiple times on multiple 
>>> platforms - in progress
>>>          (Passed on Mac so far)
>>>
>>> Thank you,
>>> Misha
>>>

[prev in list] [next in list] [prev in thread] [next in thread]