[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8229930: internal_name() in annotations.hpp returns "{constant pool}"
From:       Harold Seigel <harold.seigel () oracle ! com>
Date:       2019-08-21 15:26:58
Message-ID: e4903e3c-ad92-1379-8a10-40dfd04c1fd6 () oracle ! com
[Download RAW message or body]

Thanks Dan!

Harold

On 8/21/2019 10:08 AM, Daniel D. Daugherty wrote:
> On 8/21/19 9:48 AM, Harold Seigel wrote:
>> Hi,
>>
>> Please review this trivial fix to correct a misspelling and a 
>> probable cut-and-paste error.
>
> I agree this is a trivial fix.
>
>
>>
>> Open Webrev: 
>> http://cr.openjdk.java.net/~hseigel/bug_8229930/webrev/index.html
>
> src/hotspot/share/oops/annotations.cpp
>        No comments.
>
> src/hotspot/share/oops/annotations.hpp
>        No comments.
>
> Thumbs up!
>
>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8229930
>>
>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>> and builds on Linux-x64, Solaris, Windows, and Mac OS X and by 
>> running JCK lang and VM tests on Linux-x64.
>
> Tier1 and Tier2 are good sanity checks. I'm hoping that we don't
> have any tests that rely on the misspelling or the cut-n-paste error.
>
> Dan
>
>
>>
>> Thanks, Harold
>>
>
[prev in list] [next in list] [prev in thread] [next in thread]