[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS) 8221726: Multiple build failures after JDK-8221698 (Remove redundant includes from popu
From:       David Holmes <david.holmes () oracle ! com>
Date:       2019-03-31 22:16:49
Message-ID: 88a8e19d-82c3-69f7-3c53-c19c689a87af () oracle ! com
[Download RAW message or body]

Hi Aleksey,

On 1/04/2019 8:04 am, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8221726
> 
> See bug for examples of build failures. Seems only ppc64le and x86_64 {minimal, zero} are affected.
> Happy to fold other fixes if other platforms are failing too.
> 
> Fix:
> 
> diff -r 7ad62bdfec59 src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp
> --- a/src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp Sun Mar 31 23:29:47 2019 +0200
> +++ b/src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp Sun Mar 31 23:52:49 2019 +0200
> @@ -28,4 +28,5 @@
>   #include "gc/shared/barrierSetAssembler.hpp"
>   #include "interpreter/interp_masm.hpp"
> +#include "runtime/jniHandles.hpp"
> 
>   #define __ masm->
> diff -r 7ad62bdfec59 src/hotspot/share/classfile/systemDictionary.hpp
> --- a/src/hotspot/share/classfile/systemDictionary.hpp  Sun Mar 31 23:29:47 2019 +0200
> +++ b/src/hotspot/share/classfile/systemDictionary.hpp  Sun Mar 31 23:52:49 2019 +0200
> @@ -31,4 +31,5 @@
>   #include "oops/symbol.hpp"
>   #include "runtime/java.hpp"
> +#include "runtime/mutexLocker.hpp"
>   #include "runtime/reflectionUtils.hpp"
>   #include "runtime/signature.hpp"

I'm struggling to see what changes in JDK-8221698 led to these problems, 
but the fixes certainly look totally appropriate. I also think this 
constitutes a trivial change and can be pushed with one Review andnot 
wait 24 hours. (If there are any issues I'll sort them out if needed.)

Aside: are there any tools that will show where a particular declaration 
is being included from? We've obviously got some interesting transitive 
closures with conditional includes.

Thanks,
David

> Testing: Linux x86_64 {server, minimal, zero}, ppc64le builds
> 
> Thanks,
> -Aleksey
> 
[prev in list] [next in list] [prev in thread] [next in thread]