[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: (trivial) 8215954: [testbug] Remove unnecessary casts in test/hotspot/gtest/threadHelper.in
From:       David Holmes <david.holmes () oracle ! com>
Date:       2018-12-28 21:29:43
Message-ID: 4e0599c0-8406-914c-b235-d199bb899313 () oracle ! com
[Download RAW message or body]

Thanks Dan!

David

On 29/12/2018 2:00 am, Daniel D. Daugherty wrote:
> Thumbs up! Agree that it is trivial.
> 
> Dan
> 
> 
> On 12/28/18 1:50 AM, David Holmes wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8215954
>> webrev: http://cr.openjdk.java.net/~dholmes/8215954/webrev/
>>
>> A leftover from JDK-8214097 that should have been cleaned up before 
>> pushing.
>>
>> --- old/test/hotspot/gtest/threadHelper.inline.hpp       2018-12-28 
>> 01:46:06.322790818 -0500
>> +++ new/test/hotspot/gtest/threadHelper.inline.hpp       2018-12-28 
>> 01:46:04.506687440 -0500
>> @@ -51,7 +51,7 @@
>>      VMThreadBlocker() {}
>>      virtual ~VMThreadBlocker() {}
>>      const char* get_thread_name_string(char* buf, int buflen) const {
>> -       return (char*) "VMThreadBlocker";
>> +       return "VMThreadBlocker";
>>      }
>>      void run() {
>>          this->set_thread_state(_thread_in_vm);
>> @@ -95,7 +95,7 @@
>>      virtual ~JavaTestThread() {}
>>
>>      const char* get_thread_name_string(char* buf, int buflen) const {
>> -       return (char*) "JavaTestThread";
>> +       return "JavaTestThread";
>>      }
>>
>>      void pre_run() {
>>
>> Thanks,
>> David
> 
[prev in list] [next in list] [prev in thread] [next in thread]