[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS): 8214208: Nestmate package validation logging/exception should include classloader info
From:       David Holmes <david.holmes () oracle ! com>
Date:       2018-11-27 21:58:46
Message-ID: bc5e1f1e-3885-6f77-4013-4554ad66d15b () oracle ! com
[Download RAW message or body]

Thanks Mandy!

Not sure it addresses the exact case that you raised, but it does help 
with those tests that load nested classes in a custom loader :)

David

PS. Once this is pushed I'll re-sync valhalla forest with mainline.

On 28/11/2018 7:55 am, Mandy Chung wrote:
> Looks good.   Thanks for improving the exception message.
> 
> Mandy
> 
> On 11/22/18 1:55 AM, David Holmes wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8214208
>> webrev: http://cr.openjdk.java.net/~dholmes/8214208/webrev/
>>
>> This is a simple change to add classloader information to the logging 
>> and exceptions related to obtaining the nest-host within the VM.
>>
>> This makes it simpler to see when tests fail due to nested types being 
>> loaded by different classloaders.
>>
>> Of course the test had to be updated to account for the additional 
>> information.
>>
>> Testing: runtime/Nestmates
>>                  tier 1 - 2
>>
>> Thanks,
>> David
> 
[prev in list] [next in list] [prev in thread] [next in thread]