[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XXS): 8209566: [TESTBUG] runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
From:       Calvin Cheung <calvin.cheung () oracle ! com>
Date:       2018-10-29 17:34:56
Message-ID: 5BD744C0.6010306 () oracle ! com
[Download RAW message or body]

Thanks for your quick review, Misha.

Calvin

On 10/29/18, 9:48 AM, Mikhailo Seledtsov wrote:
> Looks good,
>
> Misha
>
> On 10/29/18, 9:43 AM, Calvin Cheung wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8209566
>>
>> The fix for JDK-8212028 decreased the timeout factor from 10 to 4. 
>> This test has been timing out occasionally in tier6 testing.
>> The timeout could be reproduced by running the test on a 
>> solaris/sparc host many times. After increasing the timeout to 240, 
>> the timeout was not seen.
>>
>> Before the timeout factor change, the effective timeout is: 120s 
>> (default) x 10 = 1200s.
>> With this change, the effective timeout is: 240s x 4 = 960s.
>>
>> Below is the diff:
>>
>> bash-4.2$ hg diff 
>> test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
>> diff --git 
>> a/test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java 
>> b/test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
>> --- 
>> a/test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
>> +++ 
>> b/test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
>> @@ -33,7 +33,7 @@
>>   * @build sun.hotspot.WhiteBox
>>   * @run driver ClassFileInstaller sun.hotspot.WhiteBox
>>   * @compile ../../test-classes/JvmtiApp.java
>> - * @run driver JvmtiAddPath
>> + * @run driver/timeout=240 JvmtiAddPath
>>   */
>>
>> Testing:
>>     Ran the test repeatedly on a solaris/sparc host with tier6 vm 
>> options.
>>
>> thanks,
>> Calvin
[prev in list] [next in list] [prev in thread] [next in thread]