[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): 8209743: [TESTBUG] java/lang/management/MemoryMXBean/LowMemoryTest2.sh
From:       Calvin Cheung <calvin.cheung () oracle ! com>
Date:       2018-08-28 18:59:46
Message-ID: 5B859BA2.1070402 () oracle ! com
[Download RAW message or body]



On 8/28/18, 11:49 AM, mandy chung wrote:
>
>
> On 8/28/18 11:34 AM, Calvin Cheung wrote:
>>
>>> How long does this test run with this patch?  fastdebug build.
>> With fastdebug and CDS archive:
>> solaris/sparcv9    12s - 27s
>> linux-x64            6s - 13s
>> macosx                6s - 11s
>>
>
> Thanks.   Not too bad.
>
>>> Is the above comment still valid?
>>
>> I'll update comment before push.
>> How about the following comment?
>>
>> # Also we set the max metaspace to 16MB/32MB - otherwise the test 
>> takes too
>> # long to run. The 32MB setting is required for running with CDS archive.
>
> This comment implies that the test detects if it's running with CDS 
> archive and uses different MaxMetaspaceSize.   I like that but I think 
> your patch unconditionally sets to 32MB.
CDS archive will be included in JDK/JRE builds for applicable platforms 
and sharing will be enabled by default on those platforms.
See RFR from Jiangli:
http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-August/033938.html

thanks,
Calvin
>
> Mandy
[prev in list] [next in list] [prev in thread] [next in thread]