[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS) 8207944: java.lang.ClassFormatError: Extra bytes at the end of class file test" possibl
From:       Harold David Seigel <harold.seigel () oracle ! com>
Date:       2018-07-30 12:47:43
Message-ID: ac4097c2-50ca-3136-2b9d-a484430b74e7 () oracle ! com
[Download RAW message or body]

You're welcome!

I wish the code was clearer about the need to handle unknown attributes.

Harold

On 7/30/2018 2:47 AM, David Holmes wrote:
> Thanks for fixing this nestmates-induced bug Harold!
>
> Cheers,
> David
>
> On 27/07/2018 3:05 AM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this JDK-11 fix for bug JDK-8207944.   The fix adds 
>> necessary handling of unknown attributes when the class file version 
>> >= JAVA_11_VERSION.   Without this fix, the class file bytes for those 
>> attributes do not get skipped over when parsing the class file, 
>> corrupting further parsing of the class file.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8207944_11/webrev/
>>
>> JBS Bug:   https://bugs.openjdk.java.net/browse/JDK-8207944
>>
>> This fix was regression tested by running JCK Lang and VM tests on 
>> Linux-x64 and by running the new test.   Testing that consists of 
>> running Mach5 tiers 1 and 2 tests and builds on Linux-X64, Windows, 
>> Solaris Sparc, and Mac OS X, and running tiers 3-5 tests on 
>> Linux-x64, is in progress.
>>
>> Thanks, Harold
>>

[prev in list] [next in list] [prev in thread] [next in thread]