[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8205422: assert(false) failed: Bad verification_type_info
From:       Harold David Seigel <harold.seigel () oracle ! com>
Date:       2018-06-25 14:24:44
Message-ID: dba7d3f2-bfdd-ab0a-cb34-22ebfec42460 () oracle ! com
[Download RAW message or body]

Thanks Coleen!

 >> Is -verify the same as -Xverify:all ?

Yes.   See java.base/share/native/libjli/java.c:

                    } else if (JLI_StrCmp(arg, "-verify") == 0) {
                            AddOption("-Xverify:all", NULL);

Harold
On 6/25/2018 10:16 AM, coleen.phillimore@oracle.com wrote:
> 
> http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/test/hotspot/jtreg/runtime/verifier/stackMapTableTests/StackMapTableTest.java.html \
>  
> 
> Is -verify the same as -Xverify:all ?
> 
> Other than this question, the change looks great.
> Coleen
> 
> On 6/22/18 1:49 PM, Harold David Seigel wrote:
> > Hi,
> > 
> > Please review this fix to prevent the debug build of the JVM from 
> > failing with an assert when the verifier tries to print a stack map 
> > containing a bad verification type.   The verifier now prints 
> > "BAD:<bad-verification-type-number>" for the illegal value type.
> > 
> > For example:
> > 
> > Stackmap Table:
> > same_frame(@15)
> > same_locals_1_stack_item_frame(@18,BAD:9)
> > same_frame(@19)
> > 
> > Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/
> > 
> > JBS Bug:   https://bugs.openjdk.java.net/browse/JDK-8205422
> > 
> > This fix was tested with Mach5 tiers 1 and 2 tests and builds on 
> > Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests 
> > on Linux-x64, and with JCK-11 Lang and VM tests.
> > 
> > Thanks, Harold
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]