[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(xxxs): 8204164: OOM-only logging in Metaspace
From:       David Holmes <david.holmes () oracle ! com>
Date:       2018-05-31 22:22:45
Message-ID: 123ccd8a-f2f9-19b3-c5ef-9f00855041cb () oracle ! com
[Download RAW message or body]

On 1/06/2018 6:37 AM, coleen.phillimore@oracle.com wrote:
> I agree, this seems good, and fine with me to remove freelist.

Have we established any policy for lifecycle management of logging tags? 
If you just rip out a tag and someone has a special logging script they 
run occasionally if they need to gather specific information, then they 
suddenly get a failure because someone decided "naw don't need that tag".

David
-----

> Coleen
> 
> 
> On 5/31/18 3:35 PM, Gerard Ziemski wrote:
>> hi Thomas,
>>
>> Your enhancement looks useful to me.
>>
>> Removing "freelist" tag from "metaspace" seems worthy of a separate 
>> issue/discussion.
>>
>>
>> cheers
>>
>>> On May 31, 2018, at 6:36 AM, Thomas Stüfe <thomas.stuefe@gmail.com> 
>>> wrote:
>>>
>>> Hi all,
>>>
>>> very tiny improvement. The intent is to be able to restrict metaspace
>>> logging to OOM situations.
>>>
>>> CR: OOM-only logging in Metaspace
>>> Webrev: 
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8204164-oom-only-logging-in-metaspace/webrev.00/webrev/ 
>>>
>>>
>>> -- 
>>>
>>> On a related note, would anyone be offended if I were to remove the
>>> "freelist" logging tag from the metaspace coding? I am not sure that
>>> is useful in any way.
>>>
>>> Thanks, Thomas
> 
[prev in list] [next in list] [prev in thread] [next in thread]