[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (s) JDK-8203435: Circular nested dynamic constant test needed to confirm JVMS resolution beh
From:       Lois Foltan <lois.foltan () oracle ! com>
Date:       2018-05-24 18:38:41
Message-ID: 7df1ca32-5ff5-163d-a420-7d54572b4783 () oracle ! com
[Download RAW message or body]

Thank you for taking doing a 2nd review!
Lois

On 5/24/2018 2:37 PM, Karen Kinnear wrote:
> Thanks Lois - looks good.
> 
> thanks,
> Karen
> 
> > On May 24, 2018, at 2:36 PM, Paul Sandoz <paul.sandoz@oracle.com> wrote:
> > 
> > +1
> > 
> > Paul.
> > 
> > > On May 24, 2018, at 10:58 AM, Lois Foltan <lois.foltan@oracle.com> wrote:
> > > 
> > > Although I have the required reviews, one off review suggestion has been to \
> > > move this test to the open/test/jdk/java/lang/invoke/condy directory where more \
> > > people can benefit.  Here is an updated webrev, test remains the same. 
> > > http://cr.openjdk.java.net/~lfoltan/bug_jdk8203435.1/webrev/
> > > 
> > > Thanks,
> > > Lois
> > > 
> > > On 5/21/2018 3:50 PM, Lois Foltan wrote:
> > > > Please review this change to add a nested circular dynamic constant test to \
> > > > confirm the JVMS 5.4.3.6 Dynamically-Computed Constant and Call Site \
> > > > Resolution behavior as discussed in \
> > > > http://mail.openjdk.java.net/pipermail/valhalla-spec-observers/2018-February/000518.html.
> > > >  
> > > > open webrev at: http://cr.openjdk.java.net/~lfoltan/bug_jdk8203435/webrev/
> > > > bug link: https://bugs.openjdk.java.net/browse/JDK-8203435
> > > > 
> > > > Testing: hs-tier1-2, jdk-tier1-3 in progress
> > > > 
> > > > Thanks,
> > > > Lois


[prev in list] [next in list] [prev in thread] [next in thread]