[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR[xxs] 8195065 runtime/appcds/ProhibitedPackage.java intermittent failure
From:       Ioi Lam <ioi.lam () oracle ! com>
Date:       2018-02-24 4:45:53
Message-ID: b0574439-a376-afb8-df9c-4b676a304de0 () oracle ! com
[Download RAW message or body]

Thanks Misha. I will do some testing and push.

- Ioi


On 2/23/18 4:15 PM, Mikhailo Seledtsov wrote:
> Fix looks good to me.
> I believe this qualifies for a trivial rule.
> 
> Thank you,
> Misha
> 
> On 2/23/18, 4:13 PM, Ioi Lam wrote:
> > https://bugs.openjdk.java.net/browse/JDK-8195065
> > http://cr.openjdk.java.net/~iklam/jdk11/8195065-cds-prohibited-package-intermittent-failure.v01/ \
> >  
> > 
> > Summary:
> > 
> > The test uses -Xshare:auto to launch a JVM process. In this sub 
> > process, the CDS archive would sometimes be disabled due to Address 
> > Space Layout Randomization, and the process would continue to 
> > execution without using the archive.
> > 
> > However, the variant of TestCommon.checkExec() used by the test 
> > assumes that -Xshare:on is used, so the test incorrectly required 
> > that that sub process must execute with the CDS archive.
> > 
> > The fix is to use a different variant of TestCommon.checkExec() that 
> > knows that -Xshare:auto is being used.
> > 
> > ( You can see this coding pattern in other tests, e.g.,
> > http://hg.openjdk.java.net/jdk/hs/file/4aa67aba6c85/test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHookTest.java#l88 \
> >  )
> > 
> > 
> > Thanks
> > - Ioi


[prev in list] [next in list] [prev in thread] [next in thread]