[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8193933: Export ClassLoaderData claim state to support interleaved object traversal
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2017-12-21 18:33:18
Message-ID: d52e1ff0-b6d0-a9ff-5082-bb670c0b456b () oracle ! com
[Download RAW message or body]

+1

Harold


On 12/21/2017 1:10 PM, coleen.phillimore@oracle.com wrote:
> Hi Markus,
> This looks fine.   Happy new year!
> Coleen
>
> On 12/21/17 12:26 PM, Markus Gronlund wrote:
>> Hi Coleen,
>>
>> We can postpone any cleanup activities in this area for 11.
>>
>> Here is a minimal change:
>>
>> http://cr.openjdk.java.net/~mgronlun/8193933/webrev02/
>>
>> Thanks
>> Markus
>>
>> -----Original Message-----
>> From: Coleen Phillimore
>> Sent: den 21 december 2017 17:15
>> To: hotspot-runtime-dev@openjdk.java.net
>> Subject: Re: RFR(S): 8193933: Export ClassLoaderData claim state to 
>> support interleaved object traversal
>>
>>
>> This bug is marked for JDK 10.   It is not appropriate to do this 
>> level of cleanup for JDK 10.
>>
>> I have only looked through the classLoaderData.hpp changes and I 
>> don't agree with the gratuituous moving functions around.   I do like 
>> removing header files and adding forward declarations, when possible, 
>> but that's a smaller change.   Also a cleanup that should be done in 
>> JDK 11, not 10.
>>
>> Thanks,
>> Coleen
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]