[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS) 8193897 - JDK-8191374 caused windows_i586 build to fail
From:       Ioi Lam <ioi.lam () oracle ! com>
Date:       2017-12-20 19:29:09
Message-ID: 8a99d7a8-dc4d-7fcf-79c4-e79a636da3b5 () oracle ! com
[Download RAW message or body]

Thanks Harold. I'll push now.

- Ioi


On 12/20/17 9:59 AM, harold seigel wrote:
> Hi Ioi,
>
> The change looks good.   Go ahead and push it.
>
> Harold
>
>
> On 12/20/2017 12:56 PM, Ioi Lam wrote:
>> Hi,
>>
>> Please review this fix for jprt breakage.
>>
>> I'd like to use the trivial fixrule since it affects JPRT.
>>
>>
>> https://bugs.openjdk.java.net/browse/JDK-8193897
>>
>>
>> --- a/src/hotspot/share/classfile/classLoader.cpp       Tue Dec 19 
>> 11:29:07 2017 -0800
>> +++ b/src/hotspot/share/classfile/classLoader.cpp       Wed Dec 20 
>> 09:44:58 2017 -0800
>> @@ -803,7 +803,7 @@
>>      bool set_base_piece = true;
>>
>>   #if INCLUDE_CDS
>> -   if (DumpSharedSpaces || UseSharedSpaces) {
>> +   if (DumpSharedSpaces) {
>>          if (!Arguments::has_jimage()) {
>>              vm_exit_during_initialization("CDS is not supported in 
>> exploded JDK build", NULL);
>>          }
>>
>>
>> The failure happens on 32-bit platforms where UseSharedSpaces is true 
>> by default.
>>
>> We actually just needed to check for DumpSharedSpaces and disable 
>> archive
>> creation for exploded builds.
>>
>> Without an archive, the user won't be able to run with CDS using an 
>> exploded build.
>> (Archive loading checks for the JVM which created the archive, so the 
>> exploded build
>> can't use an archive created by another JVM).
>>
>> Thanks
>> - Ioi
>

[prev in list] [next in list] [prev in thread] [next in thread]