[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: RFR[M] 8193672 - [test] Enhance vm.cds property to check for all conditions required to run CDS 
From:       "Lindenmaier, Goetz" <goetz.lindenmaier () sap ! com>
Date:       2017-12-18 17:19:47
Message-ID: 012f56f7e179478fb3f260cbb8363c95 () sap ! com
[Download RAW message or body]

Hi Ioi, 

Thanks for spreading the use of this property!
Looks good.

Best regards,
  Goetz.

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces@openjdk.java.net] On \
                Behalf Of Dmitry Samersoff
Sent: Monday, December 18, 2017 5:51 PM
To: Ioi Lam <ioi.lam@oracle.com>; hotspot-runtime-dev@openjdk.java.net
Subject: Re: RFR[M] 8193672 - [test] Enhance vm.cds property to check for all \
conditions required to run CDS tests

Ioi,

The fix looks good to me.

-Dmitry


17/12/2017 04:26, Ioi Lam пишет:
> Hi,
> 
> Please review this fix that touches many test cases with simple changes.
> 
> - https://bugs.openjdk.java.net/browse/JDK-8193672
> - 
> http://cr.openjdk.java.net/~iklam/jdk11/8193672.enhance.vm.cds.test.property.v01/ 
> 
> 
> 
> SUMMARY
> =======
> 
> All the test changes look like this:
> 
> Before:
> 
> * AppCDS does not support uncompressed oops"
> * @requires (vm.opt.UseCompressedOops == null) | 
> (vm.opt.UseCompressedOops == true)
> 
> After:
> 
> * @requires vm.cds
> 
> This makes the tests easier to maintain, as we no longer need to
> leak the implementation dependencies of CDS into all of the test cases.
> 
> 
> The check for "(vm.opt.UseCompressedOops == null) | 
> (vm.opt.UseCompressedOops == true)"
> is now moved into whitebox.cpp (the first file in the webrev page).
> 
> 
> TESTING
> =======
> 
> Tested with hotspot tier1 and tier2, which include all the CDS tests.
> 
> 
> Thanks!
> - Ioi
> 


[prev in list] [next in list] [prev in thread] [next in thread]