[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: Review Request JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767
From:       coleen.phillimore () oracle ! com
Date:       2017-12-15 15:54:05
Message-ID: 9a31e94b-2cc0-ef7c-076e-ad2710f5088c () oracle ! com
[Download RAW message or body]


Hi, The hotspot part looks good.
Thanks!
Coleen

On 12/12/17 7:42 PM, mandy chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8193325/webrev.00/
>
> This fixes the bug in hotspot that sets the bci field as int but it's 
> of short type and also StackFrameInfo to return a proper bci value.   
> Coleen suggests not to change set_bci to take jushort but instead do 
> the cast as in the proposed fix.   The VM is in favor of C++ types and 
> stop propagation of Java types.   bci is of int in VM implementation 
> and so be consistent.
>
> Mandy
> [1] 
> mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050581.html

[prev in list] [next in list] [prev in thread] [next in thread]