[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8167372: Add code to check for getting oops while thread is in native
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2017-12-11 18:49:45
Message-ID: 3829cbb1-2e51-2585-5a1f-35ed18af33fa () oracle ! com
[Download RAW message or body]

Thanks Jiangli!

Harold

On 12/11/2017 1:49 PM, Jiangli Zhou wrote:
> Hi Harold,
>
> Looks good.
>
> Thanks,
> Jiangli
>
>> On Nov 29, 2017, at 5:40 AM, harold seigel <harold.seigel@oracle.com> wrote:
>>
>> Please review this updated webrev that adds the assert suggested below by Aleksey.
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8167372.2/webrev/index.html
>>
>> This update was re-tested with the same tests as the original webrev.
>>
>> Note that this change will be pushed post JDK-10.
>>
>> Thanks, Harold
>>
>>
>> On 11/16/2017 10:06 AM, Aleksey Shipilev wrote:
>>> On 11/16/2017 02:38 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this JDK-10 enhancement for bug JDK-8167372.  As described in the bug, this fix helps
>>>> check for naked oops.  The fix was tested with JCK lang and VM tests, JTReg hotspot and many JTReg
>>>> JDK tests, M5 tier1 - tier5 tests, and JPRT.
>>>>
>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8167372/webrev/index.html
>>> This looks good.
>>>
>>> It probably makes sense to assert that JNIHandle::resolve path that unpacks the naked oops also has
>>> thread in proper state? This would expose failures like in JDK-8191227 [1] better.
>>>
>>> Thanks,
>>> -Aleksey
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8191227
>>>

[prev in list] [next in list] [prev in thread] [next in thread]