[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8068314: "Java fields that are currently set during shared space dumping" comment is inc
From:       Jiangli Zhou <jiangli.zhou () oracle ! com>
Date:       2017-09-15 23:00:41
Message-ID: 272BCD61-E2CA-47D4-A6F3-905AA5D0723F () oracle ! com
[Download RAW message or body]

Thanks, Harold!

Jiangli

> On Sep 15, 2017, at 1:36 PM, harold seigel <harold.seigel@oracle.com> wrote:
> 
> Hi Jiangli,
> 
> The changes look good.
> 
> Thanks, Harold
> 
> 
> On 9/15/2017 3:29 PM, Jiangli Zhou wrote:
> > Hi,
> > 
> > Please review following changes for 8068314.
> > 
> > webrev: http://cr.openjdk.java.net/~jiangli/8068314/webrev.00/ \
> >                 <http://cr.openjdk.java.net/~jiangli/8068314/webrev.00/>
> > bug: https://bugs.openjdk.java.net/browse/JDK-8068314 \
> > <https://bugs.openjdk.java.net/browse/JDK-8068314> 
> > The change cleans up out dated code and comments in universe_post_init(). The \
> > preallocated out_of_memory errors could be used during CDS/AppCDS dump time, \
> > especially with the use of java class loader instances and executing java code \
> > during dump time. Also, initializing the error messages during dump time has no \
> > unwanted side effects on the archived data. 
> > Tested with CDS/AppCDS related tests.
> > 
> > Thanks,
> > Jiangli
> 


[prev in list] [next in list] [prev in thread] [next in thread]