[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: [s390] RFR(XS): 8184267: Restore register from stack uses wrong offset
From:       "Schmidt, Lutz" <lutz.schmidt () sap ! com>
Date:       2017-07-25 14:23:45
Message-ID: AD42C8A7-D1FB-4BDD-98EB-BF2E4051B12C () sap ! com
[Download RAW message or body]

Thank you, Martin!

Regards, Lutz

 

On 24.07.2017, 18:10, "Doerr, Martin" <martin.doerr@sap.com> wrote:

    Hi Lutz,
    
    thanks for fixing this obvious bug. Reviewed and pushed.
    
    Best regards,
    Martin
    
    -----Original Message-----
    From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces@openjdk.java.net] \
On Behalf Of Schmidt, Lutz  Sent: Montag, 17. Juli 2017 16:23
    To: Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; \
hotspot-runtime-dev@openjdk.java.net  Subject: Re: [s390] RFR(XS): 8184267: Restore \
register from stack uses wrong offset  
    Thank you, Goetz!
    
    Regards, Lutz
    
    
     
    
    On 17.07.2017, 16:16, "Lindenmaier, Goetz" <goetz.lindenmaier@sap.com> wrote:
    
        Hi Lutz, 
        
        took me a while to see the bug, good catch :)
        Looks good.
        
        Goetz.
        
        > -----Original Message-----
        > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
        > bounces@openjdk.java.net] On Behalf Of Schmidt, Lutz
        > Sent: Mittwoch, 12. Juli 2017 14:30
        > To: hotspot-runtime-dev@openjdk.java.net
        > Subject: [s390] RFR(XS): 8184267: Restore register from stack uses wrong
        > offset
        > 
        > Dear community,
        > 
        > may I please request reviews for this little s390-only bug fix? It corrects \
                the
        > offset used to restore a previously saved argument register value. At the
        > same time, the save/restore code is improved by the use of "store multiple"
        > and "load multiple" instructions.
        > 
        > Bug: https://bugs.openjdk.java.net/browse/JDK-8184267
        > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8184267.00/
        > 
        > Thank you very much!
        > Lutz
        
        
    
    


[prev in list] [next in list] [prev in thread] [next in thread]