[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS) 8181450: assert in BasicHashtable::verify_table
From:       coleen.phillimore () oracle ! com
Date:       2017-06-16 14:02:22
Message-ID: c10fd4c7-578e-a2f1-3098-9fd0711dc655 () oracle ! com
[Download RAW message or body]

Thank you for the code review.  I had already started the push job as a 
semi-trivial change.  Thank you for the consulting!
Coleen


On 6/16/17 9:49 AM, Daniel D. Daugherty wrote:
> On 6/15/17 6:21 PM, coleen.phillimore@oracle.com wrote:
>> Summary: remove assert as it has small probability of happening and 
>> add some logging
>>
>> Tested new logging with -Xlog:hashtables with failed tests. See bug 
>> report for more information.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8181450.01/webrev
>
> src/share/vm/classfile/placeholders.cpp
>     No comments.
>
> src/share/vm/utilities/hashtable.cpp
>     No comments.
>
> src/share/vm/utilities/hashtable.hpp
>     No comments.
>
> Thumbs up! This has been a very interesting hunt!
>
> Dan
>
>
>> bug link https://bugs.openjdk.java.net/browse/JDK-8181450
>>
>> Thanks,
>> Coleen
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]