[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: 8181087: Module system implementation refresh (6/2017 update)
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2017-06-15 14:28:33
Message-ID: 20564742-43D1-4470-A413-5D84F7028FA6 () oracle ! com
[Download RAW message or body]


> On Jun 15, 2017, at 12:34 AM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
> 
> > 
> > java/lang/Module.java
> > 901     void implAddOpensToAllUnnamed(Iterator<String> iterator) {
> > 902         if (jdk.internal.misc.VM.isModuleSystemInited()) {
> > 903             iterator.forEachRemaining(pn ->
> > 904                 implAddExportsOrOpens(pn, ALL_UNNAMED_MODULE, true, true));
> > 905             return;
> > 906         }
> > 
> > AFAICT this should only be called during module system initialization.
> > When will this method be called after initPhase 2?
> It's for use during startup (initPhase2) only. If called later then it works as if \
> the module somehow reflectively opened the packages to all unnamed modules. I \
> wouldn't object to changing it to throwing an exception (assuming that is what you \
> are thinking) as the JDK doesn't have any use for this after initPhase2.

Yes this is what I am thinking.  This method should catch when it's called which is \
not expected.


Mandy=


[prev in list] [next in list] [prev in thread] [next in thread]