[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8179243 - [TESTBUG] CDS tests should be excluded from running with -UseCompressedOops
From:       mikhailo <mikhailo.seledtsov () oracle ! com>
Date:       2017-04-26 17:37:05
Message-ID: 9550e718-8ffd-51cc-69e9-1cb8b0c22456 () oracle ! com
[Download RAW message or body]

David, Jiangli, Serguei,

     Thank you for review,

Misha


On 04/25/2017 07:33 PM, serguei.spitsyn@oracle.com wrote:
> Hi Misha,
>
> It looks good to me.
>
> Thanks,
> Serguei
>
>
> On 4/25/17 16:43, mikhailo wrote:
>> Please review this simple change that adds "@requires" statements
>> to prevent CDS tests from execution with CompressedOops off,
>> since CDS is only available with compressed oops on.
>> Also, a small correction to SharedArchiveFile.java to instruct
>> Java Process Builder to pass the VM Test flags to the child VMs 
>> processes.
>>
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179243
>> Webrev: http://cr.openjdk.java.net/~mseledtsov/8179243.00/
>> Testing:
>>   Local:
>>     Linux-x64
>>     Ran CDS tests (hotspot/test/runtime/SharedArchiveFile/):
>>       - default run w/o any additional flags
>>       - with -XX:-UseCompressedOops, -XX:+UseCompressedOops
>>       - multi-flag combo run, exercising major CL VM flags
>>         UseG1GC, UseParallelGC, UseSerialGC, CMS, Xcomp
>>       All PASS
>>
>>   Automated multi-platform testing:
>>       hotspot_cds with default VM options
>>       hotspot_cds with -XX:-UseCompressedOops
>>       hotspot_cds with -XX:+UseCompressedOops
>>       hotspot_cds with -XX:+UseSerialGC
>>       In progress...
>>
>>
>> Thank you,
>> Misha
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]