[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: (10 XXS) RFR: 8166927: interfaceSupport.hpp has ancient comments about TSO
From:       David Holmes <david.holmes () oracle ! com>
Date:       2017-04-06 21:42:05
Message-ID: f8bcee83-e2ac-4eff-56c4-dc122fe1fb1d () oracle ! com
[Download RAW message or body]

Thanks Dan, Lois and Coleen for the additional reviews!

It will take longer to write the commit message than it did to fix the 
issue :)

David

On 6/04/2017 10:31 PM, coleen.phillimore@oracle.com wrote:
>
> Looks good.
> Coleen
>
> On 4/6/17 2:24 AM, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8166927
>> webrev: http://cr.openjdk.java.net/~dholmes/8166927/webrev/
>>
>> Patch below for convenience.
>>
>> Simply deleted the ancient and incorrect:
>>
>> "(assumes total store ordering!  -Urs)"
>>
>> Thanks,
>> David
>> -----
>>
>> --- old/src/share/vm/runtime/interfaceSupport.hpp    Thu Apr  6
>> 02:19:56 2017
>> +++ new/src/share/vm/runtime/interfaceSupport.hpp    Thu Apr  6
>> 02:19:54 2017
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights
>> reserved.
>> + * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights
>> reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -115,7 +115,7 @@
>>      assert(from != _thread_in_native, "use transition_from_native");
>>      assert((from & 1) == 0 && (to & 1) == 0, "odd numbers are
>> transitions states");
>>      assert(thread->thread_state() == from, "coming from wrong thread
>> state");
>> -    // Change to transition state (assumes total store ordering! -Urs)
>> +    // Change to transition state
>>      thread->set_thread_state((JavaThreadState)(from + 1));
>>
>>      // Make sure new state is seen by VM thread
>> @@ -146,7 +146,7 @@
>>    static inline void transition_and_fence(JavaThread *thread,
>> JavaThreadState from, JavaThreadState to) {
>>      assert(thread->thread_state() == from, "coming from wrong thread
>> state");
>>      assert((from & 1) == 0 && (to & 1) == 0, "odd numbers are
>> transitions states");
>> -    // Change to transition state (assumes total store ordering! -Urs)
>> +    // Change to transition state
>>      thread->set_thread_state((JavaThreadState)(from + 1));
>>
>>      // Make sure new state is seen by VM thread
>> @@ -179,7 +179,7 @@
>>    static inline void transition_from_native(JavaThread *thread,
>> JavaThreadState to) {
>>      assert((to & 1) == 0, "odd numbers are transitions states");
>>      assert(thread->thread_state() == _thread_in_native, "coming from
>> wrong thread state");
>> -    // Change to transition state (assumes total store ordering! -Urs)
>> +    // Change to transition state
>>      thread->set_thread_state(_thread_in_native_trans);
>>
>>      // Make sure new state is seen by GC thread
>
[prev in list] [next in list] [prev in thread] [next in thread]