[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8176471: [TESTBUG] runtime/modules/IgnoreModulePropertiesTest.java fails with OpenJDK:
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2017-03-14 13:34:02
Message-ID: d7045f63-ca14-07cc-e7d7-7cad1dd9626c () oracle ! com
[Download RAW message or body]

Hi David,

Thanks for looking at this change.

I thought about removing the string checks and just relying on the calls 
to output.shouldHaveExitValue(0) to indicate success. But ultimately 
decided to keep the string checks.  Perhaps they check that 'java 
-version' produced actual output?

Harold


On 3/13/2017 8:37 PM, David Holmes wrote:
> Hi Harold,
>
> On 14/03/2017 5:18 AM, harold seigel wrote:
>> Hi,
>>
>> Please review these fixes for two tests that incorrectly parse the
>> output from 'java -version' commands for the open jdk build.
>
> I agree these changes will "fix" the tests when run on OpenJDK build.
>
> However I don't see how checking for these strings is actually testing 
> anything relevant to the test being executed.
>
> Thanks,
> David
>
>> Open Webrevs:
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8176471_jdk/webrev/
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8176471_hs/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8176471
>>
>> The fixed tests were tested on open fastdebug and product builds, and on
>> a fastdebug closed build.
>>
>> Thanks, Harold
>>
>>

[prev in list] [next in list] [prev in thread] [next in thread]