[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2017-03-10 13:02:26
Message-ID: 080388d2-9503-92bf-c548-8584d5706d10 () oracle ! com
[Download RAW message or body]

Hi David,

Thanks for the review!

Harold


On 3/9/2017 8:56 PM, David Holmes wrote:
> On 10/03/2017 2:21 AM, harold seigel wrote:
>> Thanks Claes!
>>
>> Here's the correct open webrev URL:
>> http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html
>
> Looks fine to me.
>
> Thanks,
> David
>
>> Harold
>>
>>
>> On 3/9/2017 11:15 AM, Claes Redestad wrote:
>>> Looks good to me!
>>>
>>> (You might want to host the webrev on cr.openjdk.java.net, though..)
>>>
>>> /Claes
>>>
>>> On 03/09/2017 04:44 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this JDK-10 fix to removing checking for duplicate
>>>> packages in the package list passed to JVM_DefineModule(). The
>>>> checking is potentially expensive and also redundant because the JDK
>>>> makes the same check.
>>>>
>>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>>>
>>>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot,
>>>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
>>>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>>>
>>>> Thanks, Harold
>>>>
>>>
>>

[prev in list] [next in list] [prev in thread] [next in thread]