[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    =?utf-8?B?UmU6IFJGUihYUyk6IDgxNzEwOTc6IENvbnZlcnQgVGVzdFJlc2VydmVkU3BhY2Vf?= =?utf-8?B?dGVzdCB0byBHd
From:       "=?utf-8?B?aWdvci5pZ25hdHlldkBvcmFjbGUuY29t?=" <igor.ignatyev () oracle ! com>
Date:       2016-12-27 14:49:49
Message-ID: 201612271449.uBREnnLb023538 () userv0122 ! oracle ! com
[Download RAW message or body]

Hi Kirill,

Looks good to me.

-- II

----- Reply message -----
From: "Kirill Zhaldybin" <kirill.zhaldybin@oracle.com>
To: "hotspot-runtime-dev@openjdk.java.net" <hotspot-runtime-dev@openjdk.java.net>, \
                "hotspot-dev developers" <hotspot-dev@openjdk.java.net>
Subject: RFR(XS): 8171097: Convert TestReservedSpace_test to Gtest
Date: Tue, Dec 27, 2016 17:41

After getting offline comments I updated webrev: 
http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171097/webrev.01/

Changes:
1. Deleted "return;" which was not needed
2. Changed two ASSERTs to EXPECTs

Thank you.

Regards, KIrill

On 12.12.2016 19:31, Kirill Zhaldybin wrote:
> Dear all,
> 
> Could you please review this fix for 8171097?
> 
> WebRev: 
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171097/webrev.00/
> CR: https://bugs.openjdk.java.net/browse/JDK-8171097
> 
> Thank you.
> 
> Regards, Kirill


[prev in list] [next in list] [prev in thread] [next in thread]