[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8171090: Convert VMStruct_test to GTest
From:       Kirill Zhaldybin <kirill.zhaldybin () oracle ! com>
Date:       2016-12-27 13:07:31
Message-ID: 35710afd-d144-22a9-54be-61e0aa8fac9d () oracle ! com
[Download RAW message or body]

Igor,

Thank you for review!

Regards, Kirill

On 27.12.2016 16:01, Igor Ignatyev wrote:
> Hi Kirill,
> 
> looks good to me. thanks for fixing that.
> 
> Cheers,
> — Igor
> > On Dec 12, 2016, at 4:27 PM, Kirill Zhaldybin <kirill.zhaldybin@oracle.com> \
> > wrote: 
> > Dear all,
> > 
> > Could you please review this fix for 8171090?
> > 
> > I added accessors to get arrays' lengths since they were defined in cpp file and \
> > separated the test into to two scenarios. 
> > WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171090/webrev.00/
> > CR: https://bugs.openjdk.java.net/browse/JDK-8171090
> > 
> > Thank you.
> > 
> > Regards, Kirill


[prev in list] [next in list] [prev in thread] [next in thread]