[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: RFR(S): 8155964 - Create a set of tests for verifying the Minimal VM
From:       "Christian Tornqvist" <christian.tornqvist () oracle ! com>
Date:       2016-08-23 12:44:40
Message-ID: 158801d1fd3c$1dc1a4b0$5944ee10$ () oracle ! com
[Download RAW message or body]

Since we'll pass -minimal in as an external flag, this shouldn't be needed. 

-----Original Message-----
From: David Holmes [mailto:david.holmes@oracle.com] 
Sent: Tuesday, August 23, 2016 8:05 AM
To: Christian Tornqvist <christian.tornqvist@oracle.com>; 'Chris Plummer' \
                <chris.plummer@oracle.com>; hotspot-runtime-dev@openjdk.java.net
Subject: Re: RFR(S): 8155964 - Create a set of tests for verifying the Minimal VM

On 23/08/2016 8:47 PM, Christian Tornqvist wrote:
> Hi Chris,
> 
> > Why does Instrumentation.java not have @requires minimal?
> It should, I'll correct this.
> 
> > Why does JMX.java have:
> > 
> > 28  * @run main/othervm -minimal JMX
> This was done to make sure the parent process was running minimal for the jcmd \
> check at line 50. This isn't needed, I'll remove it.

Hmm I thought it was needed else the parent VM will show for the jcmd request. ??

David
-----

> Thanks,
> Christian
> 
> -----Original Message-----
> From: Chris Plummer [mailto:chris.plummer@oracle.com]
> Sent: Monday, August 22, 2016 5:15 PM
> To: Christian Tornqvist <christian.tornqvist@oracle.com>; 
> hotspot-runtime-dev@openjdk.java.net
> Subject: Re: RFR(S): 8155964 - Create a set of tests for verifying the 
> Minimal VM
> 
> Hi Christian,
> 
> Overall it looks good. Thanks for adding these tests. Just a few questions:
> 
> Why does Instrumentation.java not have @requires minimal?
> 
> Why does JMX.java have:
> 
> 28  * @run main/othervm -minimal JMX
> 
> Have you tested with a jre that only has minimalvm and java.base?
> 
> thanks,
> 
> Chris
> 
> On 8/22/16 12:03 PM, Christian Tornqvist wrote:
> > Hi everyone,
> > 
> > 
> > 
> > Please review this change that adds a set of tests for the Minimal 
> > variant of the JVM. The Minimal JVM is a subset that excludes some 
> > functionality, the tests here are intended to test verify that trying 
> > to use this excluded functionality doesn't lead to any unexpected errors/crashes.
> > 
> > 
> > 
> > Verified by running the tests on Linux ARMv7 and Linux x86.
> > 
> > 
> > 
> > Webrev:
> > 
> > http://cr.openjdk.java.net/~ctornqvi/webrev/8155964/webrev.00/
> > 
> > 
> > 
> > Bug (unfortunately not visible):
> > 
> > https://bugs.openjdk.java.net/browse/JDK-8155964
> > 
> > 
> > 
> > Thanks,
> > 
> > Christian
> > 
> > 
> > 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]